refactor(runtime): establish deployment foundation - #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local Agent Hostconcept with a deployment-focused architecture: one Agent Runtime with Embedded and future Shared deployment optionsScope boundary
This PR does not add a user-visible Shared mode,
--shared, a Host command, or any CLI/TUI/GUI/Remote/SDK Host consumer. It does not define Session, Turn, Tool, MCP, Permission, UserInput, event replay, or controller wire contracts. Existing product entrypoints remain Embedded and unchanged.The IPC crate currently has no reverse dependency outside itself. It is intentionally removable if the first reviewed consumer chooses another transport or Shared deployment is not activated.
Architecture and product impact
Validation
cargo test -p bitfun-agent-runtime-ipc— 14 passedcargo clippy -p bitfun-agent-runtime-ipc --all-targets -- -D warningscargo check -p bitfun-agent-runtime-ipc --tests --target x86_64-unknown-linux-gnucargo test -p bitfun-services-core --features runtime-ownership --test runtime_ownership_contracts— 2 passedcargo check -p bitfun-services-core --features runtime-ownership --target x86_64-unknown-linux-gnucargo check --workspacenode scripts/core-boundaries/self-test.mjsnode scripts/check-core-boundaries.mjsnode --test scripts/check-core-boundaries.test.mjs— 16 passednode scripts/check-repo-hygiene.mjsgit diff --checkcargo test --workspaceis currently blocked by the upstreamgcwing/mainRelay Server compatibility fixture:src/apps/relay-server/tests/library_compat.rsinitializesAppStatewithout the existingpage_browser_authfield. This PR has no diff in that fixture or itsAppStateowner; the focused tests above and the full workspace check pass.Review note
This change was AI-assisted and then independently reviewed from architecture and product-scope perspectives. The review specifically rejected exposing a new Host product concept, connecting CLI/TUI to SDK Host, adding Shared business operations, or allowing a future private TCP module to bypass the local-only boundary.